label: Don't set out parameters twice
authorTimm Bäder <mail@baedert.org>
Tue, 3 May 2016 20:04:58 +0000 (16:04 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Tue, 3 May 2016 20:25:57 +0000 (16:25 -0400)
We set them later again when we calculate the vertical size, so just
move the general assignment to -1 into the horizontal branch.

gtk/gtklabel.c

index 6498a3bcbeac769b759df8362741b0b2ff41aeb1..1089242db5aa379d16e7081e4a2d2cf9ee7b12b7 100644 (file)
@@ -3767,12 +3767,6 @@ gtk_label_get_preferred_size (GtkWidget      *widget,
     gtk_misc_get_padding (GTK_MISC (label), &xpad, &ypad);
   G_GNUC_END_IGNORE_DEPRECATIONS
 
-  if (minimum_baseline)
-    *minimum_baseline = -1;
-
-  if (natural_baseline)
-    *natural_baseline = -1;
-
   gtk_label_get_preferred_layout_size (label, &smallest_rect, &widest_rect);
 
   /* Now that we have minimum and natural sizes in pango extents, apply a possible transform */
@@ -3837,6 +3831,12 @@ gtk_label_get_preferred_size (GtkWidget      *widget,
 
       *minimum_size += xpad * 2;
       *natural_size += xpad * 2;
+
+      if (minimum_baseline)
+        *minimum_baseline = -1;
+
+      if (natural_baseline)
+        *natural_baseline = -1;
     }
   else /* GTK_ORIENTATION_VERTICAL */
     {